Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot read property 'tagName' of null #1655

Merged
merged 2 commits into from Oct 22, 2021
Merged

fix: Cannot read property 'tagName' of null #1655

merged 2 commits into from Oct 22, 2021

Commits on Oct 21, 2021

  1. fix: Cannot read property 'tagName' of null 

    Have a look at this issue #1154 .
https://codesandbox.io/s/loving-matsumoto-hp985?file=/index.html
Open devtools and click the *blank space* of svg(not path) will reproduce this issue.

`parentNode` may be `null`.
https://github.com/docsifyjs/docsify/blob/develop/src/core/router/history/html5.js#L25-L27

However, hash router has fixed this issue馃槣.
https://github.com/docsifyjs/docsify/blob/develop/src/core/router/history/hash.js#L47-L49
    @woshiguabi
    woshiguabi committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    ad9d1b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Merge branch 'develop' into patch-1

    @sy-records
    sy-records committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    ae4a2f6 View commit details
    Browse the repository at this point in the history