Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix id with pure number. #2021

Merged
merged 5 commits into from Apr 22, 2023
Merged

fix: fix id with pure number. #2021

merged 5 commits into from Apr 22, 2023

Conversation

Koooooo-7
Copy link
Member

Summary

As per to #2019 mentioned, when the id is pure number, it can not go to the number anchor via id=number directly.
Although it should work in HTML5 which we supported but somehow it still breaks on browser.

close #2019

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 10:02am

@Koooooo-7 Koooooo-7 requested a review from a team April 17, 2023 09:34
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 747646d:

Sandbox Source
docsify-template Configuration
gallant-scott-6ih7ug Issue #2019

@Koooooo-7 Koooooo-7 merged commit f4f21a3 into develop Apr 22, 2023
10 checks passed
@sy-records sy-records deleted the fix-id branch June 19, 2023 01:10
@sy-records sy-records restored the fix-id branch June 19, 2023 01:10
@sy-records sy-records deleted the fix-id branch June 19, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waline notification view page doesn't work for docsify
1 participant