Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Adds deployment to Kinsta Static Site Hosting #2299

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

palmiak
Copy link

@palmiak palmiak commented Nov 6, 2023

Summary

This PR adds instructions on how to deploy Docsify to Kinsta Static Site Hosting

Related issue, if any:

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 9:23am

@Koooooo-7 Koooooo-7 added docs related to the documentation of docsify itself good first PR labels Nov 10, 2023
5. During the build settings, Kinsta will automatically try to fill out the **Build command**, **Node version**, and **Publish directory**. If it won't, fill out the following:

- Build command: leave empty
- Node version: `18.16.0`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying a node version in these docs means these instructions will become outdated as nobody is going to update 18.16.0 to the latest stable build. Will Kinsta not choose a reasonable node version by default? If so, consider changing 18.16.0 to something like leave on default selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs related to the documentation of docsify itself good first PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants