You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, using relative links to non-markdown files are broken and give a 404. This PR addresses this and should fix cases such as described in #1929 and others.
Related documentation has been updated, if needed -> Not needed
Related tests have been added or updated, if needed
Does this PR introduce a breaking change?
No, although there has been some refactoring.
Tested in the following browsers:
Chrome
Firefox
Safari
Edge
Notes
Relative linked files without extension are still seen as markdown files: I don't know if this is intentional or not, but seems counterintuitive. Better would be to require to link to .md-files with an explicit mention of the .md-extension (e.g. [test](test.md) of [test](./test.md).
MartenBE
changed the title
Better support for relative links (e.g. download links) for non-markdown files
[WIP] Better support for relative links (e.g. download links) for non-markdown files
Nov 16, 2023
@MartenBE Hey can you add some non-.md files to the Docsify site so that we can manually test as well? (We can view the deployment for the PR for manual test). Once the PR is ready then we can delete them.
I've added some test files, but the latest commits feel "off". It is rather unstable and sometimes seems to cause reload loops and weird behavior. Unfortunately, I am out of my league here as my understanding of docsify is rather superficial. I think the original commit (e594e39) was (although not as architectal "proper" as we would like) more robust, and also uses the same workings as image links.
In the previous months, we have decided to go with MkDocs instead of Docsify due to this bug and other reasons. So I'll probably won't work on this any further.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MartenBE
changed the title
Summary
Currently, using relative links to non-markdown files are broken and give a 404. This PR addresses this and should fix cases such as described in #1929 and others.
Related issue, if any:
#1929
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
No, although there has been some refactoring.
Tested in the following browsers:
Notes
Relative linked files without extension are still seen as markdown files: I don't know if this is intentional or not, but seems counterintuitive. Better would be to require to link to .md-files with an explicit mention of the .md-extension (e.g.
[test](test.md)of[test](./test.md).