Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update local and Vercel preview. Fix CSS watch functionality. #2348

Merged
merged 14 commits into from Dec 22, 2023

Conversation

jhildenbiddle
Copy link
Member

@jhildenbiddle jhildenbiddle commented Dec 21, 2023

This PR continues the cleanup work done in #2316 by removing the need for additional files to be generated or copied to render either a preview or production docs site. The /docs/ directory is a ready-to-be-served production site, and the local and Vercel server configurations are used to virtualize the necessary changes based on the files in /docs/.

FWIW, I would have done this in #2316, but I was unaware of Vercel's middleware capabilities.

If this PR is accepted, PRs #2317 and #2322 can be closed.

Summary

  • Update Vercel preview to be served from virtual /preview directory instead of /preview.html file.
  • Update local dev server configuration to serve /docs/index.html with URL rewrites
  • Update local prod server configuration to serve /docs/ directory without modification
  • Remove build:html script and resulting preview.html file
  • Fix CSS watch functionality

Related issue, if any:

#2218

close #2317
close #2322

What kind of change does this PR introduce?

Bugfix
Build-related changes

For any code change,

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 3:27am

@sy-records sy-records merged commit 167596b into develop Dec 22, 2023
9 checks passed
@sy-records sy-records deleted the vercel-preview-update branch December 22, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants