refactor: event modernization and optimization #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor methods names and functionality - Replace scroll listeners with observers - Replace Tweezer-based scrolling with native scroll methods - Remove tweezer.js dependency - Remove redundant method calls - Rename $resetEvents to onNavigate - Rename __scrollActiveSidebar to onRender - Remove __getAndActive - Remove __sticky
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Apr 11, 2024
# Conflicts: # src/core/event/index.js
jhildenbiddle
changed the title
sy-records
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The motivation for this PR is to remove/replace event handling code no longer needed for legacy browsers and to optimize event handling so that we can more easily address the many scroll-related issues for the upcoming v5 release or in a future release following v5.
No features or tests have been added or removed. All of the pre-existing tests continue to pass.
Updates to Docsify's event handling are as follows:
IntersectionObserverinstead ofscrollevents)Included but not directly event-handling related:
NOTES:
/src/core/event/index.js. Other file updates are either small changes to accommodate the updates to/src/core/event/index.jsor are unrelated build-related changes.Related issue, if any:
None
What kind of change does this PR introduce?
Bugfix
Code style update
Refactor
For any code change,
N/A
Does this PR introduce a breaking change?
No
Tested in the following browsers: