Consider container as always set

This implies removing an unnecessary check, and documenting the property holding the container as non-nullable.
doctrine · Jan 20, 2020 · 2834c4b · 2834c4b
1 parent bb1ac0d
commit 2834c4b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Repository/ContainerRepositoryFactory.php b/Repository/ContainerRepositoryFactory.php
@@ -18,7 +18,7 @@ final class ContainerRepositoryFactory implements RepositoryFactory
     /** @var ObjectRepository[] */
     private $managedRepositories = [];
 
-    /** @var ContainerInterface|null */
+    /** @var ContainerInterface */
     private $container;
 
     /**
@@ -40,7 +40,7 @@ public function getRepository(EntityManagerInterface $entityManager, $entityName
         $customRepositoryName = $metadata->customRepositoryClassName;
         if ($customRepositoryName !== null) {
             // fetch from the container
-            if ($this->container && $this->container->has($customRepositoryName)) {
+            if ($this->container->has($customRepositoryName)) {
                 $repository = $this->container->get($customRepositoryName);
 
                 if (! $repository instanceof ObjectRepository) {