Default to real-utf8 when no charset is provided #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Nov 28, 2019
No, this was just a case of @nicolas-grekas and I not realising that the bug should be fixed in 2.0.1. New features should still go to |
|
I didn't realise master was aliased to 2 and not 3. Not a smart idea indeed. Not sure why it's not like in ORM or DBAL though. Also, I see that the alias is 2.0, it should probably be 2.1, right? |
|
I haven't updated the alias yet. The alias will change to 3.0 once we start working on 3.0. Until then, it can stay at 2.x (pointing to the next minor release): we're not merging PRs with BC breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back port of #1070 since that was inadvertently merged to master only.