Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting of managers on kernel reset #1102

Conversation

alexander-schranz
Copy link
Contributor

Not sure about this change but bin/console debug:container --parameter doctrine.entity_managers

does return in my case:

    'default' => 'doctrine.orm.default_entity_manager',

and if the value instead of key is used it will end up in a

Doctrine ORM Manager named "doctrine.orm.default_entity_manager'" does not exist.

Exception

@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2019

Thanks for the PR. I was working on a fix to be merged to the 1.12.x as that's the lowest supported branch where the issue appears. See #1103.

@alcaeus alcaeus closed this Dec 18, 2019
@alexander-schranz
Copy link
Contributor Author

@alcaeus oh sorry forget to change the target branch. Thank you for working on it 👍

@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2019

No, thank YOU for working on a fix. I was writing the test when I saw your PR, but it lacked tests so I continued. Had I known you were working on a test as well I'd have stopped, but as is rebasing would've taken more time. We'll have this fixed in a few minutes.

@alexander-schranz
Copy link
Contributor Author

@alcaeus Thx for the fast release :)

@alexander-schranz alexander-schranz deleted the bugfix/reset-manager branch December 18, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants