Merge release 2.0.7 into master #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a side effect, this makes the code a bit more forward-compatible with recent versions of PHPUnit, that have that return type declaration on setUp().
Add void return type declaration to tests
That means: - methods in final classes - final methods (none of those found) - private methods - methods in Tests (that excludes setUp(), tearDown() and test*, which are handled with an automated tool in a separate commit)
Add type declarations where backwards compatible
In some scenarios involving long running processes and proxies, resetting the entity manager results in a creation of a new entity manager, while some services still hold a reference to the old one, which keeps its previous state. This abandons resetting the entity manager in favor of a call to clear() on the existing entity manager if it is open. Fixes #1112
…kernel-reset Fix desynchronized entity managers after kernel reset
* 1.12.x: Clear open entity managers on kernel reset
alcaeus
deleted the
2.0.x-merge-up-into-master_5e22f41c5c0099.36134783
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 2.0.7
2.0.7
Improvement
1122: Add type declarations where backwards compatible thanks to @greg0ire
1121: Add void return type declaration to tests thanks to @greg0ire