Commands shortcuts #1132
Merged
Commands shortcuts #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
force-pushed
the
feat/command-shortcuts
branch
from
9827b29
to
97f07f4
Compare
|
Please improve your commit message according to the contributing guide. |
greg0ire
reviewed
Jan 27, 2020
Guikingone
force-pushed
the
feat/command-shortcuts
branch
2 times, most recently
from
6b7135f
to
7106ce4
Compare
greg0ire
approved these changes
Jan 27, 2020
ostrolucky
requested changes
Jan 27, 2020
Guikingone
force-pushed
the
feat/command-shortcuts
branch
2 times, most recently
from
505e09c
to
9155243
Compare
ostrolucky
previously approved these changes
Jan 28, 2020
Pierstoval
suggested changes
Jan 28, 2020
Guikingone
force-pushed
the
feat/command-shortcuts
branch
from
9155243
to
891398a
Compare
|
Just pushed a refactor when it comes to |
ostrolucky
reviewed
Jan 28, 2020
This feature allow to use shortcuts when possible instead of full InputOption name. Implement doctrine#1072
Guikingone
force-pushed
the
feat/command-shortcuts
branch
from
ac780f4
to
a491fc9
Compare
ostrolucky
approved these changes
Jan 28, 2020
greg0ire
reviewed
Jan 28, 2020
| /** | ||
| * @dataProvider provideForceOption | ||
| */ | ||
| public function testExecute(array $options) : void |
There was a problem hiding this comment.
I've never tried this myself, but I think using variadics here could help simplify the data providers
SenseException
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone 馃憢
As notified here: #1072, here's the PR for the commands shortcuts, I need to finish the tests (on commands that don't have ones for now).
Feel free to give feedback 馃檪