Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return type to fixture file #1139

Closed
wants to merge 1 commit into from
Closed

Add missing return type to fixture file #1139

wants to merge 1 commit into from

Conversation

DurandSacha
Copy link

No description provided.

@alcaeus
Copy link
Member

alcaeus commented Feb 18, 2020

Closing here: Adding a return type to a non-final, non-private method in a non-final class is a BC break and not suitable for a new minor release. We'll be adding return type hints in 3.0.

@alcaeus alcaeus closed this Feb 18, 2020
@ostrolucky
Copy link
Member

This is ok to do for tests in same fashion as #1121 did

@ostrolucky ostrolucky reopened this Feb 18, 2020
ostrolucky
ostrolucky requested changes Feb 18, 2020
View reviewed changes
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change commit message. E.g. "Add missing return type to fixture file"

@alcaeus
Copy link
Member

alcaeus commented Feb 18, 2020

Sorry, didn’t see this was a test fixture 👍

@DurandSacha DurandSacha changed the title PHP Typography for method Add missing return type to fixture file Feb 18, 2020
SenseException
SenseException requested changes Feb 18, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You cannot change the laws of PHP, Jim".

The method is returning something despite having a void return type.

@ostrolucky
Copy link
Member

🤦‍♂ indeed

@ostrolucky ostrolucky closed this Feb 18, 2020
@SenseException SenseException mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky requested changes

@SenseException SenseException SenseException requested changes

@Yohann76 Yohann76 Yohann76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DurandSacha @alcaeus @ostrolucky @SenseException @Yohann76