Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker interface for event subscriber autoconfiguration #623

Merged

Conversation

alterphp
Copy link
Contributor

@alterphp alterphp commented Mar 2, 2020

Totally copied from doctrine/DoctrineBundle#1119 !

This is first step in order to split Doctriner EventSubscriber autoconfiguration and then resolve conflicts introduced in https://github.com/KnpLabs/DoctrineBehaviors/blob/master/src/Bundle/DependencyInjection/DoctrineBehaviorsExtension.php#L29

@alterphp
Copy link
Contributor Author

alterphp commented Mar 2, 2020

@malarzm
Copy link
Member

malarzm commented Mar 22, 2020

@alterphp thanks for the PR and sorry for the long wait!

Not sure if line should be adapted too https://github.com/doctrine/DoctrineMongoDBBundle/pull/623/files#diff-21bb4bdcf714a43b98948d9c96f74a1fR96

What line are you referring to?

Also would you mind adding a note to https://github.com/doctrine/DoctrineMongoDBBundle/blob/master/Resources/doc/events.rst? You may take a page from https://symfony.com/doc/master/bundles/DoctrineMongoDBBundle/first_steps.html#service-repositories

@malarzm
Copy link
Member

malarzm commented Mar 22, 2020

@alterphp I'm afraid a conflict popped up, can you please rebase your changes atop current master? Also once you'll be rebasing, please squash your commits into 1.

@alterphp
Copy link
Contributor Author

alterphp commented Mar 22, 2020 via email

@alterphp alterphp force-pushed the enhance/autoconfigure-event-subscriber branch 3 times, most recently from 19c4433 to 75631e6 Compare March 22, 2020 13:31
@alterphp
Copy link
Contributor Author

Not sure if line should be adapted too https://github.com/doctrine/DoctrineMongoDBBundle/pull/623/files#diff-21bb4bdcf714a43b98948d9c96f74a1fR96
What line are you referring to?

@malarzm I do not remember what I was thinking... Sorry. I htink it's ok now !

@alterphp alterphp force-pushed the enhance/autoconfigure-event-subscriber branch from 75631e6 to a2a8c5e Compare March 22, 2020 16:10
@alterphp alterphp force-pushed the enhance/autoconfigure-event-subscriber branch from a2a8c5e to f746217 Compare March 22, 2020 16:14
@malarzm
Copy link
Member

malarzm commented Mar 22, 2020

Thanks a lot @alterphp!

Yes, i'm not done, i had to switch to m'y dad duties

Sorry then, got a notification about a commit and acted on it :)

@malarzm malarzm added this to the 4.2.0 milestone Mar 22, 2020
@malarzm malarzm merged commit 1b6e079 into doctrine:master Mar 22, 2020
@alterphp
Copy link
Contributor Author

No worries, you could not guess !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants