Allow usage of self:: accessor for constants

[bertrandseurot]

ex: @Annotation(self::VALUE)
Fixes #269

[stof]

I think self should be forbidden when parsing an annotation on a trait, as self:: would resolve to the class using the trait in PHP, and we don't know that in the current code.

[bertrandseurot]

I think self should be forbidden when parsing an annotation on a trait, as self:: would resolve to the class using the trait in PHP, and we don't know that in the current code.

Seems to work in traits too. Am I missing something ?

[stof]

@bertrandseurot if you use self:: in the code of a trait, it refers to the class using the trait, not to the trait itself, as trait are basically compiler-based copy/paste. See https://3v4l.org/BSPC3 for the proof.

So supporting self:: in annotations on traits would require that it works the same. If that's the case, this is fine.

[bertrandseurot]

@stof This will fails only if you try to directly parse a trait out of a class context :

$reflectionTrait = new \ReflectionClass( RandomTrait::class );
$reader = new AnnotationReader();
$reader->getMethodAnnotations( reflectionTrait->getMethod( 'randomMethod')  );

It coul'd be annoying if you wanted to do that in order to get the traits annotation cached, and use this cache later when parsing classes using this trait. But since the php Reflection API does not not allow to know if a property/method of a trait is overriden in the class, I think this strategy is currently not possible.

I confirm that it works in other cases (tested in testMethodAnnotationSupportsSelfAccessorForConstants() and testPropertyAnnotationSupportsSelfAccessorForConstants)

[bertrandseurot]

Because of a force-push, this PR seems stuck in a "changes requested" status. Sorry for that, it's my first PR. Should I open another or it is not a problem ?

[greg0ire]

It's not a problem and it's not because of a force-push. You need to get another review from @stof , or to get somebody from the team to dismiss his review.

[bertrandseurot]

OK, thank you !

[beberlei]

This looks good and brings annotations in line with how PHP 8 attributes work.

handled