Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle blank lines between class properties #295

Merged
merged 1 commit into from
Oct 15, 2022
Merged

feat: handle blank lines between class properties #295

merged 1 commit into from
Oct 15, 2022
+63 −18

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Oct 9, 2022 •
edited
Loading

The settings is:

$minLinesCountBeforeWithComment = 1;
$maxLinesCountBeforeWithComment = 1;
$minLinesCountBeforeWithoutComment = 0;
$maxLinesCountBeforeWithoutComment = 1;

@simPod simPod force-pushed the property-spacing branch 6 times, most recently from ca219e1 to e9b7fc5 Compare October 9, 2022 09:09
@simPod simPod marked this pull request as ready for review October 9, 2022 09:10
@simPod simPod requested a review from a team as a code owner October 9, 2022 09:10
malarzm
malarzm previously approved these changes Oct 9, 2022
View reviewed changes
ostrolucky
ostrolucky previously approved these changes Oct 9, 2022
View reviewed changes
derrabus
derrabus previously approved these changes Oct 9, 2022
View reviewed changes
@simPod simPod dismissed stale reviews from derrabus, ostrolucky, and malarzm via 9943239 October 15, 2022 08:49
@simPod
feat: handle blank lines between class properties

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
ecc6746
@simPod simPod requested a review from Ocramius October 15, 2022 08:53
Ocramius
Ocramius approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting, @simPod!

@greg0ire greg0ire added this to the 11.0.0 milestone Oct 15, 2022
@greg0ire greg0ire merged commit f2488f5 into doctrine:11.0.x Oct 15, 2022
@greg0ire
Copy link
Member

Thanks @simPod !

@simPod simPod deleted the property-spacing branch October 15, 2022 11:56
@simPod simPod mentioned this pull request Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius

@ostrolucky ostrolucky

@malarzm malarzm

@derrabus derrabus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@simPod @greg0ire @Ocramius @ostrolucky @derrabus @malarzm