Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Bash explicitly as default shell in Makefile #313

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Apr 22, 2023

GNU make uses /bin/sh by default if the SHELL variable is not set to a different value (see Choosing the Shell).

In my environment (and in many of my previous bashism incursions), I found myself fighting with syntax issues derived from the fact that [ x == y ] does not work with sh:

/bin/sh: 1: [: unexpected operator

See:

BTW, I've opted to set /bin/bash as the default shell instead of changing the script syntax to make it compatible with /bin/sh, because the shebangs at the bin/ directory are already using /bin/bash.

@phansys phansys marked this pull request as ready for review April 22, 2023 09:40
@greg0ire greg0ire requested a review from a team April 22, 2023 13:35
@greg0ire greg0ire merged commit c86a025 into doctrine:11.1.x Apr 23, 2023
12 checks passed
@greg0ire greg0ire added this to the 11.1.1 milestone Apr 23, 2023
@greg0ire greg0ire added the CI label Apr 23, 2023
@greg0ire
Copy link
Member

Thanks @phansys !

@greg0ire greg0ire added Improvement and removed CI labels Apr 23, 2023
@phansys phansys deleted the makefile_shell branch April 23, 2023 11:59
@greg0ire greg0ire modified the milestones: 11.1.1, 12.0.0 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants