Fix SQLite temp table name must not contain dot

doctrine · Apr 5, 2024 · 2591f16 · 2591f16
1 parent 14cd853
commit 2591f16
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/Platforms/SqlitePlatform.php b/src/Platforms/SqlitePlatform.php
@@ -1150,7 +1150,12 @@ public function getAlterTableSQL(TableDiff $diff)
         $sql      = [];
         $tableSql = [];
         if (! $this->onSchemaAlterTable($diff, $tableSql)) {
-            $dataTable = new Table('__temp__' . $table->getName());
+            $tableName = $table->getName();
+            if (strpos($tableName, '.') !== false) {
+                [, $tableName] = explode('.', $tableName, 2);
+            }
+
+            $dataTable = new Table('__temp__' . $tableName);
 
             $newTable = new Table(
                 $table->getQuotedName($this),

diff --git a/tests/Platforms/SqlitePlatformTest.php b/tests/Platforms/SqlitePlatformTest.php
@@ -646,6 +646,26 @@ public function getAlterTableRenameColumnSQL(): array
         ];
     }
 
+    public function testGeneratesAlterTableRenameColumnSQLWithSchema(): void
+    {
+        $this->platform->disableSchemaEmulation();
+
+        $table = new Table('main.t');
+        $table->addColumn('a', Types::INTEGER);
+
+        $tableDiff                      = new TableDiff('t');
+        $tableDiff->fromTable           = $table;
+        $tableDiff->renamedColumns['a'] = new Column('b', Type::getType(Types::INTEGER));
+
+        self::assertSame([
+            'CREATE TEMPORARY TABLE __temp__t AS SELECT a FROM main.t',
+            'DROP TABLE main.t',
+            'CREATE TABLE main.t (b INTEGER NOT NULL)',
+            'INSERT INTO main.t (b) SELECT a FROM __temp__t',
+            'DROP TABLE __temp__t',
+        ], $this->platform->getAlterTableSQL($tableDiff));
+    }
+
     /**
      * {@inheritDoc}
      */