Fix unwanted SQLite schema emulation in SqliteSchemaManager

doctrine · Feb 24, 2024 · 4aadd00 · 4aadd00
1 parent 1452a09
commit 4aadd00
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/Platforms/SqlitePlatform.php b/src/Platforms/SqlitePlatform.php
@@ -908,7 +908,7 @@ public function getTemporaryTableName($tableName)
      */
     public function canEmulateSchemas()
     {
-        Deprecation::trigger(
+        Deprecation::triggerIfCalledFromOutside(
             'doctrine/dbal',
             'https://github.com/doctrine/dbal/pull/4805',
             'SqlitePlatform::canEmulateSchemas() is deprecated.',

diff --git a/src/Schema/SqliteSchemaManager.php b/src/Schema/SqliteSchemaManager.php
@@ -704,7 +704,9 @@ protected function selectTableColumns(string $databaseName, ?string $tableName =
 
         if ($tableName !== null) {
             $conditions[] = 't.name = ?';
-            $params[]     = str_replace('.', '__', $tableName);
+            $params[]     = $this->_platform->canEmulateSchemas()
+                ? str_replace('.', '__', $tableName)
+                : $tableName;
         }
 
         $sql .= ' WHERE ' . implode(' AND ', $conditions) . ' ORDER BY t.name, c.cid';
@@ -729,7 +731,9 @@ protected function selectIndexColumns(string $databaseName, ?string $tableName =
 
         if ($tableName !== null) {
             $conditions[] = 't.name = ?';
-            $params[]     = str_replace('.', '__', $tableName);
+            $params[]     = $this->_platform->canEmulateSchemas()
+                ? str_replace('.', '__', $tableName)
+                : $tableName;
         }
 
         $sql .= ' WHERE ' . implode(' AND ', $conditions) . ' ORDER BY t.name, i.seq';
@@ -755,7 +759,9 @@ protected function selectForeignKeyColumns(string $databaseName, ?string $tableN
 
         if ($tableName !== null) {
             $conditions[] = 't.name = ?';
-            $params[]     = str_replace('.', '__', $tableName);
+            $params[]     = $this->_platform->canEmulateSchemas()
+                ? str_replace('.', '__', $tableName)
+                : $tableName;
         }
 
         $sql .= ' WHERE ' . implode(' AND ', $conditions) . ' ORDER BY t.name, p.id DESC, p.seq';