Merge pull request #5345 from andrew-demb/avoid-log-connection-url

Redact connection URL from logs as it may contain sensitive data
doctrine · Apr 5, 2022 · 719663b · 719663b
2 parents 1062be9 + 07496af
commit 719663b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Logging/Driver.php b/src/Logging/Driver.php
@@ -47,6 +47,10 @@ private function maskPassword(array $params): array
             $params['password'] = '<redacted>';
         }
 
+        if (isset($params['url'])) {
+            $params['url'] = '<redacted>';
+        }
+
         return $params;
     }
 }
diff --git a/tests/Logging/MiddlewareTest.php b/tests/Logging/MiddlewareTest.php
@@ -45,6 +45,7 @@ public function testConnectAndDisconnect(): void
                         'params' => [
                             'username' => 'admin',
                             'password' => '<redacted>',
+                            'url' => '<redacted>',
                         ],
                     ],
                 ],
@@ -54,6 +55,7 @@ public function testConnectAndDisconnect(): void
         $this->driver->connect([
             'username' => 'admin',
             'password' => 'Passw0rd!',
+            'url' => 'mysql://user:secret@localhost/mydb',
         ]);
     }