Enable strict types #2854
Merged
Enable strict types #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Loads of string casts to be added 😅 |
morozov
force-pushed
the
develop
branch
2 times, most recently
from
12fb8e1
to
a14b808
Compare
morozov
force-pushed
the
develop
branch
3 times, most recently
from
7b7cffe
to
c5e8a7c
Compare
morozov
force-pushed
the
develop
branch
3 times, most recently
from
fd275f8
to
c78e0e5
Compare
morozov
force-pushed
the
develop
branch
2 times, most recently
from
72cddfb
to
d8f1786
Compare
morozov
force-pushed
the
develop
branch
3 times, most recently
from
67bd64c
to
7e5fb71
Compare
morozov
force-pushed
the
develop
branch
2 times, most recently
from
a640b82
to
e7b6c16
Compare
Majkl578
force-pushed
the
strict-types
branch
2 times, most recently
from
ad01eea
to
beb6031
Compare
morozov
reviewed
Mar 30, 2019
| @@ -273,7 +275,7 @@ public function testGeneratesForeignKeySqlOnlyWhenSupportingForeignKeys() | |||
| } | |||
| } | |||
|
|
|||
| protected function getBitAndComparisonExpressionSql($value1, $value2) | |||
There was a problem hiding this comment.
I don't understand, I added typehints.
There was a problem hiding this comment.
Sorry. The change is correct. I was saying that this issue wouldn't be possible on PHP 7.1 which doesn't allow loosening argument types in subclasses. I oversaw it recently in #3498.
| $extraParameters = array_slice(func_get_args(), 3); | ||
|
|
||
| if (count($extraParameters) !== 0) { | ||
| $extraParameters[0] = $extraParameters[0] ?? 0; |
There was a problem hiding this comment.
I don't really see how we can improve here. Unlike the userland optional arguments defaulting to some value, the internal arguments are counted, so we have to respect the expected number of arguments being passed and their types.
morozov
reviewed
Mar 30, 2019
morozov
approved these changes
Apr 2, 2019
Ocramius
approved these changes
Apr 2, 2019
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enable strict types
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Enable strict types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.