Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Driver::getDatabase() in favor of Connection::getDatabase() #3606

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Removed Driver::getDatabase() in favor of Connection::getDatabase() #3606

merged 1 commit into from
Jun 13, 2019

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 12, 2019 •
edited

Q A
Type improvement
BC Break yes

Fixes: #3592.

  1. The changes from the end user perspective are stated in UPGRADE.md.
  2. Some unit tests have been removed as no longer relevant.
  3. The code is still covered by functional tests, specifically the ones which perform schema introspection.
  4. I didn't add tests for changing the database on the fly since it's not currently supported by the abstraction. The main goal is to make DBAL not hinder valid scenarios which it doesn't explicitly support.

@morozov morozov added the WIP label Jun 12, 2019
@morozov morozov added this to the 3.0.0 milestone Jun 12, 2019
@morozov morozov requested a review from jwage June 13, 2019 01:51
jwage
jwage approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@jwage jwage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤟

@morozov morozov merged commit 4255137 into doctrine:develop Jun 13, 2019
@morozov morozov deleted the issues/3592 branch June 13, 2019 04:16
morozov added a commit that referenced this pull request Jun 13, 2019
@morozov
Merge pull request #3606 from morozov/issues/3592
b4c2cf3 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
@morozov morozov self-assigned this Jun 13, 2019
@morozov morozov mentioned this pull request Jun 13, 2019
Closed
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3606 from morozov/issues/3592
514acd1 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3606 from morozov/issues/3592
25068cb 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3606 from morozov/issues/3592
119891b 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3606 from morozov/issues/3592
37b4c10 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3606 from morozov/issues/3592
1990159 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3606 from morozov/issues/3592
9061a7a 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
morozov added a commit to morozov/dbal that referenced this pull request Aug 27, 2019
@morozov
Merge pull request doctrine#3606 from morozov/issues/3592
761fc50 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
morozov added a commit that referenced this pull request Nov 2, 2019
@morozov
Merge pull request #3606 from morozov/issues/3592
e5b500a 
Removed Driver::getDatabase() in favor of Connection::getDatabase()
@morozov morozov mentioned this pull request Jun 12, 2020
Merged
@morozov morozov mentioned this pull request Jun 17, 2020
Merged
2 tasks
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Jun 17, 2020
@morozov morozov mentioned this pull request Nov 28, 2020
Closed
@morozov morozov mentioned this pull request Nov 11, 2021
Closed
ThomasLandauer added a commit to ThomasLandauer/DoctrineFixturesBundle that referenced this pull request Nov 11, 2021
@ThomasLandauer
Fixing database "name" (=path) for SQLite
42a800e 
Since DBAL 3.0 (see doctrine/migrations#1028), the message currently reads for SQLite:
> Careful, database "" will be purged. Do you want to continue? (yes/no)

Neither @Ocramius (see doctrine/dbal#3606 (comment)) nor me (see doctrine/dbal#4982) succeeded in convincing @morozov to continue returning the file path ;-) So it looks like the fix needs to be done here...

Suggestion: What about adding the platform too? So the message would be:
> Careful, MySQL database "foo" will be purged. Do you want to continue? (yes/no)

`doctrine/migrations` is currently broken too:

> WARNING! You are about to execute a migration in database "<unnamed>" that could result in schema changes and data loss. Are you sure you wish to continue? (yes/no) [yes]:

So when done here, I'm going to submit the same there  (i.e. follow up of doctrine/migrations#1028)
@ThomasLandauer ThomasLandauer mentioned this pull request Nov 11, 2021
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwage jwage jwage approved these changes

@Ocramius Ocramius Ocramius approved these changes

Assignees

@morozov morozov

Labels
BC Break Connections Databases Drivers Improvement Schema Introspection
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@morozov @jwage @Ocramius