Do not require hostname for non-persistent MySQL connection and require for persistent #3943
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Apr 11, 2020
…re for persistent
morozov
commented
Apr 11, 2020
| namespace Doctrine\DBAL\Driver\Mysqli; | ||
|
|
||
| /** | ||
| * @internal |
There was a problem hiding this comment.
Also, note that I marked it as @internal (there's a plan to do the same for the rest of the named exceptions in newer versions). This way, we can rework them at any time w/o breaking other's code who should rely only on higher-level classes and interfaces.
greg0ire
approved these changes
Apr 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3942.
According to the documentation, the hostname may be omitted and will default to "localhost". However, given the fact that the persistent connection flag is passed as part of the hostname, the hostname cannot be omitted for persistent connection.
The issue is not reproducible on 2.x because the "Undefined index" notice is suppressed by the error handler:
dbal/lib/Doctrine/DBAL/Driver/Mysqli/MysqliConnection.php
Lines 67 to 70 in 35beaca