Skip to content

Add tests for fetch*() methods of Portability\Result #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 9, 2020

Q A
Type improvement
BC Break no

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
@morozov morozov added this to the 3.0.0 milestone Jun 9, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #4058 into 3.0.x will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              3.0.x    #4058      +/-   ##
============================================
+ Coverage     78.09%   78.16%   +0.07%     
  Complexity     4603     4603              
============================================
  Files           189      189              
  Lines         11552    11552              
============================================
+ Hits           9021     9030       +9     
+ Misses         2531     2522       -9     
Impacted Files Coverage Δ Complexity Δ
src/Portability/Result.php 100.00% <0.00%> (+31.03%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48625f1...dded534. Read the comment docs.

@morozov morozov requested a review from greg0ire June 9, 2020 06:39
@morozov morozov merged commit 66b1f3d into doctrine:3.0.x Jun 9, 2020
@morozov morozov self-assigned this Jun 9, 2020
@morozov morozov deleted the portability-result-tests branch June 14, 2020 00:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants