Skip to content

Remove platform-specific portability mode constants #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 11, 2020

Q A
Type improvement
BC Break yes

See #4061 for more details.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #4064 into 3.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              3.0.x    #4064   +/-   ##
=========================================
  Coverage     78.25%   78.25%           
  Complexity     4604     4604           
=========================================
  Files           190      190           
  Lines         11585    11585           
=========================================
  Hits           9066     9066           
  Misses         2519     2519           
Impacted Files Coverage Δ Complexity Δ
src/Portability/Connection.php 100.00% <ø> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2fcaee...7b937a8. Read the comment docs.

@morozov morozov merged commit 4b2fed5 into doctrine:3.0.x Jun 11, 2020
@morozov morozov deleted the remove-portability-platform-constants branch June 11, 2020 19:15
@morozov morozov self-assigned this Jun 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants