Clean up redundant implements #4323
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenMorel see the rationale in #3746.
Yes, but most likely it's not going to happen. I'd like to get rid of this interface entirely. The idea is that the driver connection should instantiate a platform. Whether it's aware of the server version or not; whether DBAL handles different server versions differently, these are implementation details that are of no interest to the API. |
morozov
approved these changes
Oct 6, 2020
|
Thanks, @BenMorel! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ServerInfoAwareConnectionextendsConnection, so it is redundant to implement both.BTW, why was
ServerInfoAwareConnectionchanged to extendConnection? I found the old design much better, when interfaces were independent, and connection classes could compose their own set of implementations. What if you need to introduceSomethingElseAwareConnectionin the future? Will it extendConnectionas well? Sure, you'll still be able to implement both of them and it will work, but will look weird if you ask me.