Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaults for MySQL table charset, collation and engine #4644

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented May 11, 2021

Q A
Type improvement
BC Break yes

Closes #4631.

@morozov morozov marked this pull request as ready for review June 6, 2021 16:33
@morozov morozov requested a review from greg0ire June 6, 2021 16:37
@greg0ire
Copy link
Member

greg0ire commented Jun 6, 2021

This probably made sense in the past: https://stackoverflow.com/questions/6769901/why-is-mysqls-default-collation-latin1-swedish-ci

I think it's now safe to assume MySQL uses sensible defaults 👍

@morozov
Copy link
Member Author

morozov commented Jun 6, 2021

Even at the times when the defaults weren't that reasonable, the user was able to specify the options that would correspond to their use case. Overriding defaults in the DBAL didn't make sense even at that time.

@morozov morozov merged commit 893b671 into doctrine:4.0.x Jun 6, 2021
@morozov morozov deleted the issues/4631 branch June 6, 2021 19:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utf8mb4_0900_ai_ci should be the default collation for server_version: '8.0'
2 participants