Configure PHP version for PHP_CodeSniffer #4697
Merged
+3
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
phpcs
fails with a bunch of false-positive errors if run on PHP 8:Note that
$object::class
is only available as of PHP 8.0. All of the errors are trigger with the assumption that the runtime PHP version (8.0) is the minimum supported version (7.3).We already have some rules specific to PHP 7.4 suppressed:
dbal/phpcs.xml.dist
Lines 40 to 45 in ce7db44
But there's a better way to configure the minimum supported PHP version.