Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Oracle 12c syntax for Top-N queries #5150

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 30, 2021

Q A
Type improvement
BC Break no

Closes #3326.

The new syntax is available starting Oracle 12c.

The unit tests around SQL are quite pointless. While they could be easily reworked, I believe it's better to remove them.

@beberlei
Copy link
Member

From https://blogs.oracle.com/pcoe/post/oracle-database-12c-release-1-12102-generally-available this looks like this was released in 2014, which is more than sufficiently long ago to remove the old behavior, but propably worthy a note somewhere that 12c is the minimum supported version now (or is it already due to other things?).

Copy link
Member

@beberlei beberlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its nice to finally get rid of this sql hackery.

@morozov
Copy link
Member Author

morozov commented Dec 30, 2021

It is mentioned in the upgrade notes (#5114).

@morozov morozov merged commit 89cd2f9 into doctrine:4.0.x Dec 30, 2021
@morozov morozov deleted the issues/3326 branch December 30, 2021 23:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI8Statement is including DOCTRINE_ROWNUM as a column to be inserted.
2 participants