Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require a WHERE in update() and delete() Connection operations #5567

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Aug 5, 2022

Sometimes, one just needs to remove all records from a cache/projection table. The UPDATE and DELETE statements do not require a WHERE clause, so it should not be enforced in the DBAL either.

If modification of all table rows should not be allowed, it should be implemented in the application code.

Closes #3164.

@morozov morozov added this to the 4.0.0 milestone Aug 5, 2022
@morozov morozov marked this pull request as ready for review August 5, 2022 15:36
@morozov morozov merged commit 20adf5f into doctrine:4.0.x Aug 5, 2022
@morozov morozov deleted the issues/3164-empty-delete-criteria branch August 5, 2022 15:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider allowing execution of Connection::delete() with no identifiers
2 participants