PHPStan 1.9.1 #5807
PHPStan 1.9.1 #5807
Conversation
| @@ -163,7 +163,6 @@ class Connection | |||
| * @param Configuration|null $config The configuration, optional. | |||
| * @param EventManager|null $eventManager The event manager, optional. | |||
| * @psalm-param Params $params | |||
| * @phpstan-param array<string,mixed> $params | |||
There was a problem hiding this comment.
PHPStan fully understands our Params type now, so we can have it analyze the @psalm-param annotation.
src/DriverManager.php
Outdated
| if ($url === null) { | ||
| throw new LogicException(preg_last_error_msg(), preg_last_error()); | ||
| } |
There was a problem hiding this comment.
I'm confident that this case never happens because the regular expressions are analyzed by PHPStan already. But apparently, it is desired that we perform an explicit null check here. See phpstan/phpstan#1901 (comment) for a discussion on this topic.
There was a problem hiding this comment.
Even when I manage to get a Process exited with code 137., there will be a string as a return type. I don't know if an evil regex could end up in a return null after some runtime, but I don't see one in our use case. I guess we can live with a null check, but if you're sure about not-null, then maybe an assert is sufficient?
There was a problem hiding this comment.
Agreed, let's go with an assert.
derrabus
force-pushed
the
bump/phpstan
branch
from
34d04dc
to
c6767c6
Compare
derrabus
force-pushed
the
bump/phpstan
branch
from
c6767c6
to
8c9e2d1
Compare
No description provided.