Merge tests for fetch behavior of freed results #5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
tests/merge-freed-result-tests
branch
2 times, most recently
from
784089e
to
b3c9dbb
Compare
derrabus
force-pushed
the
tests/merge-freed-result-tests
branch
from
b3c9dbb
to
92ddda8
Compare
greg0ire
approved these changes
Nov 6, 2022
SenseException
approved these changes
Nov 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test
StatementTest::testFetchFromExecutedStatementWithFreedResult()actually tests behavior of the result classes for calling fetch methods after the result has been freed. InResultTestwe have a similar test that is limited to two drivers only. I think, we can and should merged these two tests.