Use a narrower return type for DriverManager::getAvailableDrivers()

[MidnightDesign]

Q	A
Type	improvement
Fixed issues

Summary

Adds a @psalm-return annotation to DriverManager::getAvailableDrivers() so the return type is narrower than just array<array-key, string>.

[greg0ire]

This should target 3.6.x

[MidnightDesign]

Would it be useful to add a "static analysis test" that checks whether the method can be used as a type guard?

$driver = getenv('DB_DRIVER');
if (!in_array($driver, DriverManager::getAvailableDrivers(), true) {
    throw new RuntimeException('...');
}
DriverManager::getConnection(['driver' => $driver]);

[derrabus]

Thank you @MidnightDesign!

We don't really have a concept for this kind of test in this repository, I guess. If this is something you want to work on, you're welcome to do so.

[MidnightDesign]

You do get what I'm saying though, right? It would be just like the tests in https://github.com/DefinitelyTyped/DefinitelyTyped

[greg0ire]

We don't really have a concept for this kind of test in this repository, I guess.

We do actually, do we not? https://github.com/doctrine/dbal/blob/3.5.x/static-analysis/driver-manager-retrieves-correct-connection-type.php

[derrabus]

Oh right, we have exactly one test! 🥳