fix platform comparator issues when using compareTables #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
fix_mysql_comparator
branch
from
f88e27f
to
5e028d1
Compare
|
Actually this also impacts other platforms. I will take a look to fix those as well here |
dmaicher
changed the title
dmaicher
force-pushed
the
fix_mysql_comparator
branch
from
5e028d1
to
495be3f
Compare
stof
reviewed
Jan 11, 2023
|
The issue fixed here seems to have been introduced in #5770, unintentionally 👍 |
dmaicher
force-pushed
the
fix_mysql_comparator
branch
from
495be3f
to
7af0e35
Compare
greg0ire
approved these changes
Jan 12, 2023
greg0ire
requested review from
derrabus,
SenseException and
stof
and removed request for
stof
stof
approved these changes
Jan 12, 2023
|
Thanks @dmaicher |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue I reported on
doctrine/migrations: doctrine/migrations#1302 (comment)When using the non-deprecated
compareTableswe basically did not normalize anything with the Mysql (and other platforms) Comparator implementation.