Flag parameters as sensitive if they could contain the database password #5866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
feature/sensitive-parameter
branch
2 times, most recently
from
e0d7f58
to
327ff4f
Compare
derrabus
force-pushed
the
feature/sensitive-parameter
branch
2 times, most recently
from
a3f25e1
to
89b5071
Compare
greg0ire
reviewed
Jan 23, 2023
derrabus
force-pushed
the
feature/sensitive-parameter
branch
2 times, most recently
from
e1aa994
to
2714750
Compare
greg0ire
reviewed
Jan 25, 2023
greg0ire
reviewed
Jan 25, 2023
greg0ire
reviewed
Jan 25, 2023
… if they could contain the database password.
greg0ire
force-pushed
the
feature/sensitive-parameter
branch
from
2714750
to
042864c
Compare
greg0ire
approved these changes
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PHP 8.2 introduced a
SensitiveParameterattribute that allows us to flag parameters that should be redacted in stack traces: https://wiki.php.net/rfc/redact_parameters_in_back_tracesThis PR uses this attribute on all parameters (that I could find) which could possibly contain the database password (or an SSL key), which also includes database URLs.