Raise exception if pg_send_*() calls fail
#5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
changed the title
pg_send_*() calls fail
It should be a functional test I think. You might try using that kind of query: |
|
That case is already well covered. Note that I'm using the async API here. Sending your query to the server will succeed. After sending the the query, I do a blocking request to fetch the result and this is where I would get an error in your case. I think I would need to unplug the ethernet cable to make one of async calls fail. And I'm not even sure if this would actually make them fail. 🙈 |
greg0ire
approved these changes
Feb 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Raising an exception in those cases is probably better than letting an
assert()fail. Not sure how to unit-test this though.