Optimize pgsql queries without parameters #5889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Max <49632507+maxm86545@users.noreply.github.com>
derrabus
force-pushed
the
improvement/optimize-pg-query
branch
from
c19f962
to
121cc38
Compare
|
@maxm86545 I tagged you as co-author because my PR somewhat builds on your code in #5887. |
greg0ire
approved these changes
Feb 1, 2023
| } | ||
|
|
||
| $result = @pg_get_result($this->connection); | ||
| assert($result !== false); |
There was a problem hiding this comment.
What should happen when a query returns 0 records? Do we still get a PgSql\Result instance?
There was a problem hiding this comment.
Yes. An empty result is still a result.
Also, that case is really well covered by functional tests. 😀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change should speed up pgsql queries without parameters a little.