Close pgsql connection in destructor #5892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bugfix/destruct-pgsql-connection
branch
from
1624e5d
to
ea6def2
Compare
Merged
greg0ire
reviewed
Feb 2, 2023
derrabus
force-pushed
the
bugfix/destruct-pgsql-connection
branch
from
ea6def2
to
e9a1e41
Compare
derrabus
force-pushed
the
bugfix/destruct-pgsql-connection
branch
from
e9a1e41
to
9c2a1bb
Compare
greg0ire
approved these changes
Feb 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found while merging up. We usually close a connection by unsetting the driver. Currently, that would keep the a pgsql connection open but inaccessible until the PHP process terminates. With this PR, I'm explicitly closing the connection when the driver connection is destructed.