[CS] Apply SlevomatCodingStandard.Commenting.AnnotationName rule

[phansys]

Q	A
Type	improvement
Fixed issues	n/a

Summary

Normalize the usage for the @inheritdoc tag.

ToDo

• Check if these changes can be covered by PHPCS.

[derrabus]

This looks like something PHPCS should do.

[phansys]

I agree, but I don't know if PHPCS has a specific rule for this or if the FunctionCommentSniff rule should be enough in this case.

[greg0ire]

Can you please open an issue about this on https://github.com/slevomat/coding-standard ?

[derrabus]

Unless we can have this fixed by PHPCS, I'd like to keep everything as inconsistent as it is.

[phansys]

Can you please open an issue about this on https://github.com/slevomat/coding-standard ?

Seems that both variants are intentionally allowed there. See:

• https://github.com/slevomat/coding-standard/blob/c831e3aa3aeed3e0c4c7cabc3a35652347ea9e50/SlevomatCodingStandard/Sniffs/Commenting/UselessInheritDocCommentSniff.php#L51-L53 (i modifier is used for the regex);
• https://github.com/slevomat/coding-standard/blob/c831e3aa3aeed3e0c4c7cabc3a35652347ea9e50/SlevomatCodingStandard/Helpers/DocCommentHelper.php#L120 (stripos() is called instead of strpos()).

[greg0ire]

I believe both are correct and mean the same thing, but I might be wrong. The sniff that detects such comments that are useless should absolutely detect both. The helper should also detect both.
If they both mean the same thing, then it's a matter of style, and a rule to pick one style over the other is 100% the job of a coding standard.

[phansys]

Unless we can have this fixed by PHPCS, I'd like to keep everything as inconsistent as it is.

@derrabus: doctrine/coding-standard#311.

[phansys]

BTW, if we are releasing new CS rules from "doctrine/coding-standard" only in major versions, couldn't we use ^12.0 here?

[greg0ire]

You're right, we probably should… not sure why we are pinning this one.