Fix binding unused parameter #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would involve using https://github.com/staabm/phpstan-dba |
greg0ire
approved these changes
Jun 28, 2023
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jun 28, 2023
* 3.7.x: PHPStan 1.10.21, PHPUnit 9.6.9, JetBrains Stubs 2023.1 (doctrine#6073) Fix binding unused parameter (doctrine#6072)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SQLServerSchemaManager::selectTableNames()binds a parameter that does not exist in the query. I don't know how we can make the CI catch this issue. This piece is covered by a test that fails on my machine, but apparently the SQL Server and driver setup that I use locally is more picky about extra parameter than the one we use on GitHub actions. 馃し馃徎