Optimize TypeRegistry::lookupName() from O(N) to O(1) #6082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
optimize_reverse_type_lookup
branch
6 times, most recently
from
5029656
to
a5e6e82
Compare
mvorisek
force-pushed
the
optimize_reverse_type_lookup
branch
from
a5e6e82
to
7f3c2bc
Compare
mvorisek
force-pushed
the
optimize_reverse_type_lookup
branch
from
7f3c2bc
to
71f1411
Compare
derrabus
requested changes
Jul 15, 2023
mvorisek
force-pushed
the
optimize_reverse_type_lookup
branch
from
71f1411
to
92a3c40
Compare
Is there any chance this can go into 3.6.x? We use lookups heavily, thus for us the O(N) performance is a "bug". |
mvorisek
force-pushed
the
optimize_reverse_type_lookup
branch
3 times, most recently
from
b3b09ad
to
ccfe3e6
Compare
No. |
derrabus
requested changes
Jul 15, 2023
mvorisek
force-pushed
the
optimize_reverse_type_lookup
branch
from
ccfe3e6
to
33be3f8
Compare
mvorisek
force-pushed
the
optimize_reverse_type_lookup
branch
from
33be3f8
to
430c9ae
Compare
derrabus
approved these changes
Jul 15, 2023
|
Thank you for this very nice improvement, @mvorisek! |
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 15, 2023
* 3.7.x: Optimize TypeRegistry::lookupName() from O(N) to O(1) (doctrine#6082) Add documentation for doctrine#6044 (doctrine#6069) Use triggerIfCalledFromOutside in listTableDetails Document alternative to Type::getName (doctrine#6077)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 15, 2023
* 3.7.x: Optimize TypeRegistry::lookupName() from O(N) to O(1) (doctrine#6082) Add documentation for doctrine#6044 (doctrine#6069) Use triggerIfCalledFromOutside in listTableDetails Document alternative to Type::getName (doctrine#6077)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 24, 2023
* 3.7.x: Avoid self deprecation about listTableColumn (doctrine#6108) Fix blob binding overwrite on DB2 (doctrine#6093) Optimize TypeRegistry::lookupName() from O(N) to O(1) (doctrine#6082) Add documentation for doctrine#6044 (doctrine#6069) Use triggerIfCalledFromOutside in listTableDetails Document alternative to Type::getName (doctrine#6077)
derrabus
pushed a commit
that referenced
this pull request
Aug 22, 2023
| Q | A |------------- | ----------- | Type | feature | Fixed issues | n/a #### Summary `Type` class has static methods for global `TypeRegistry` instance shorter access like `Type::getType`. This feature adds a static method for `TypeRegistry::lookupName`. Thanks to #6082, the reverse lookup is O(1) thus fine to be used massively - for ex. schema introspection returns type as object, and this method is needed to obtain a string name. In DBAL 4.0, the method can be renamed to `Type::getName(Type $type): string` to be more consistent with `Type::getType(string $name): Type`.
cgknx
pushed a commit
to cgknx/dbal
that referenced
this pull request
Aug 30, 2023
| Q | A |------------- | ----------- | Type | performance issue | Fixed issues | n/a #### Summary We use a lot of custom types and migration from `Type::getName()` to `TypeRegistry->lookupName()` discovered us the reverse lookup was very slow (O(N)). This PR makes it O(1). ~Index is initialized lazily on the 1st reverse lookup.~ The type registry is expected to not hold duplicate type instances and this PR fixes it, in doctrine#6083 (comment) I was requested to fix it in this PR instead of a separate one.
cgknx
pushed a commit
to cgknx/dbal
that referenced
this pull request
Aug 30, 2023
| Q | A |------------- | ----------- | Type | feature | Fixed issues | n/a #### Summary `Type` class has static methods for global `TypeRegistry` instance shorter access like `Type::getType`. This feature adds a static method for `TypeRegistry::lookupName`. Thanks to doctrine#6082, the reverse lookup is O(1) thus fine to be used massively - for ex. schema introspection returns type as object, and this method is needed to obtain a string name. In DBAL 4.0, the method can be renamed to `Type::getName(Type $type): string` to be more consistent with `Type::getType(string $name): Type`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use a lot of custom types and migration from
Type::getName()toTypeRegistry->lookupName()discovered us the reverse lookup was very slow (O(N)). This PR makes it O(1).Index is initialized lazily on the 1st reverse lookup.The type registry is expected to not hold duplicate type instances and this PR fixes it, in #6083 (comment) I was requested to fix it in this PR instead of a separate one.