Fix self deprecation from getCustomSchemaOptions

[VincentLanglet]

Q	A
Type	bug
Fixed issues

Summary

getCustomSchemaOptions is used here:

dbal/src/Schema/Comparator.php

Lines 677 to 678 in 62cce0a

	$customOptions1 = $column1->getCustomSchemaOptions();
	$customOptions2 = $column2->getCustomSchemaOptions();

And diffColumn is used inside Comparator::compareTables, I asume that's why the deprecation was only "if call outside".

dbal/src/Schema/Comparator.php

Lines 609 to 616 in 62cce0a

	public function diffColumn(Column $column1, Column $column2)
	{
	Deprecation::triggerIfCalledFromOutside(
	'doctrine/dbal',
	'https://github.com/doctrine/dbal/pull/5650',
	'%s is deprecated. Use diffTable() instead.',
	__METHOD__,
	);

[greg0ire]

I'm not sure I understand. If you stop calling diffColumn, the issue will go away, won't it?

[VincentLanglet]

I'm not sure I understand. If you stop calling diffColumn, the issue will go away, won't it?

I'm not the one calling diffColumn, it's called here:

dbal/src/Schema/Comparator.php

Line 348 in 62cce0a

$changedProperties = $this->diffColumn($column, $toColumn);

by the compareTables method, which is not deprecated (and called by doctrine migrations).

[greg0ire]

Thanks, I understand now 👍

[greg0ire]

Thanks @VincentLanglet !