Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary array type #6134

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Add binary array type #6134

merged 2 commits into from
Aug 28, 2023

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Aug 23, 2023

Q A
Type feature
Fixed issues

Summary

Superseeds #5994

Changes to his PR:

  • Removed binding of BINARY in IBM DB2 as it makes no difference to the query.
  • Fixed IBM DB2 test failures. It seems like DB2 Binary is just VARCHAR with FOR BIT and we passed characters (pack produced one character) to the Database and expected that it converts the character to binary. That seems not to happen with DB2, so I changed it to send always binary data.

(Never used DB2 before, why do people still use it? 馃ぃ )

@derrabus derrabus changed the base branch from 3.6.x to 3.7.x August 27, 2023 12:27
@derrabus
Copy link
Member

Thank you. New features need to target the next minor release which is 3.7 currently. Can you please resolve the conflicts?

@shyim
Copy link
Contributor Author

shyim commented Aug 27, 2023

Done :)

@derrabus derrabus mentioned this pull request Aug 28, 2023
Closed
@derrabus derrabus added this to the 3.7.0 milestone Aug 28, 2023
@derrabus derrabus merged commit 4117fec into doctrine:3.7.x Aug 28, 2023
78 of 79 checks passed
@derrabus
Copy link
Member

Thank you @AndriusUkelis and @shyim!

@shyim shyim deleted the add-binary-array-type branch August 28, 2023 11:38
@shyim
Copy link
Contributor Author

shyim commented Sep 14, 2023

Is there a timeline when 3.7.0 will be released? or can we help you in some way to do it :)

@derrabus
Copy link
Member

derrabus commented Sep 14, 2023 •
edited

Is there a timeline when 3.7.0 will be released?

As soon as I find time to. 馃檪

or can we help you in some way to do it :)

  • As always, browse new issues and open PRs.
  • Look into the 3.7.0 milestone and review/test what's in there.
  • Test your projects against 3.7.x-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
New Feature Prepared Statements
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shyim @derrabus