Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to correct MR for mysql deprecation #6156

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

BackEndTea
Copy link
Contributor

Q A
Type improvement
Fixed issues

Summary

The link of the deprecation is to the postgress deprecation, rather than the mysql one.

This will however break the reference for people who ignore this wit ignoreDeprecations, so i'm not sure if its worth fixing, or if we should instead add a comment with the correct MR above it.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Let's see what the others think about it.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't go for this level of backwards-compatibility, although well spotted breaking change.

@greg0ire greg0ire added this to the 3.6.7 milestone Sep 19, 2023
@greg0ire greg0ire merged commit 8e0e268 into doctrine:3.6.x Sep 19, 2023
80 checks passed
@greg0ire
Copy link
Member

Thanks @BackEndTea

@BackEndTea
Copy link
Contributor Author

Thanks @greg0ire & @SenseException !

@BackEndTea BackEndTea deleted the patch-2 branch September 20, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants