Generalize CustomIntrospectionTest #6210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/custom-introspection-test
branch
3 times, most recently
from
fb96d1a
to
bbb5b39
Compare
derrabus
changed the title
derrabus
force-pushed
the
improvement/custom-introspection-test
branch
from
bbb5b39
to
afe8a9a
Compare
derrabus
force-pushed
the
improvement/custom-introspection-test
branch
from
afe8a9a
to
081184a
Compare
greg0ire
approved these changes
Nov 5, 2023
derrabus
added a commit
that referenced
this pull request
Nov 5, 2023
* 3.7.x: Generalize CustomIntrospectionTest (#6210)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 5, 2023
* 3.8.x: Generalize CustomIntrospectionTest (doctrine#6210) Run tests on MySQL 8.2 (doctrine#6207) MySQLSchemaManager. Check expected database type for json columns only. (doctrine#6189) Make the type annotation for CompositeExpression::count more specific (doctrine#6188)
allan-simon
pushed a commit
to allan-simon/dbal
that referenced
this pull request
Nov 13, 2023
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | Follows doctrine#6189 #### Summary This PR improves the test added in doctrine#6189 by allowing it to run on other platforms than MySQL/MariaDB and by using non-deprecated APIs only. This should make it easier to merge this test and later changes to it up to the 4.0.x branch. I've skipped Oracle though because I currently don't have a local Oracle setup to test against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the test added in #6189 by allowing it to run on other platforms than MySQL/MariaDB and by using non-deprecated APIs only. This should make it easier to merge this test and later changes to it up to the 4.0.x branch.
I've skipped Oracle though because I currently don't have a local Oracle setup to test against.