-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.4 to CI #6348
Closed
Closed
Add PHP 8.4 to CI #6348
Changes from all commits
Commits
Show all changes
956 commits
Select commit
Hold shift + click to select a range
35192e8
Merge pull request #5648 from morozov/remove-schema-manager-create-sc…
morozov 9cee7b7
Merge branch '3.5.x' into 4.0.x
morozov a8f939a
Make internal Comparator methods protected
morozov 075848c
Merge pull request #5652 from morozov/comparator-internal-protected
morozov e7b326c
Remove property-based schema comparison APIs
morozov 1f4ca72
Merge pull request #5649 from morozov/remove-changed-properties
morozov f84cf59
Remove leftovers of handling foreign keys on non-InnoDB engines for M…
morozov b4e4c74
Merge branch '3.5.x' into 4.0.x
morozov 2f562d6
Rework functional tests for default values on SQL Server
morozov c8d2c3d
Introspect default constraint name
morozov 06732b8
Merge pull request #5664 from morozov/remove-non-innodb-fk-leftovers
morozov 0e15462
Merge pull request #5662 from morozov/sql-server-default-constraint-name
morozov 039b945
Merge branch '3.5.x' into 4.0.x
morozov 58a47c8
Remove conditional comments for MySQL older than 5.1.16
morozov d1a5672
Remove support for "unique" and "check" column properties
morozov 50ede2d
Remove SchemaDiff::$fromSchema
morozov 774af88
Merge pull request #5675 from morozov/remove-mysql-5.0-leftovers
morozov b4c294b
Merge pull request #5655 from morozov/remove-unique-check
morozov 4f009c1
Merge pull request #5676 from morozov/remove-schema-diff-from-schema
morozov e35aef9
Remove support for renaming tables via TableDiff
morozov 350149d
Merge pull request #5677 from morozov/remove-table-diff-new-name
morozov 598feec
Remove leftovers of renaming default contraints
morozov 85a631b
Merge pull request #5679 from morozov/remove-sql-server-default-const…
morozov b24280d
Merge branch '3.5.x' into 4.0.x
morozov 6381aca
Remove TableDiff::$name and getName()
morozov 76635d3
Merge pull request #5683 from morozov/remove-table-diff-name
morozov 2373c42
Mark ColumnDiff properties as private and read-only
morozov 06243b7
Merge pull request #5684 from morozov/column-diff-private-properties
morozov a71d512
Remove workaround for PHP bug in PostgreSQL exception handler
morozov e652aab
Merge pull request #5696 from morozov/remove-pgsql-exception-handling…
morozov 07f9202
Merge branch '3.5.x' into 4.0.x
morozov 8cdded8
Remove platform parameter of wrapper Connection
morozov 0019c7f
Merge pull request #5703 from morozov/remove-connection-platform
morozov d213b16
Remove redundant quotes in exception messages
morozov 55eb5d4
Remove driver name aliases
morozov 13f6f4f
Merge pull request #5704 from morozov/remove-driver-name-aliases
morozov 18a3bca
Update Doctrine Coding Standard to 10.0
morozov abff3d8
Merge pull request #5706 from morozov/coding-standard-10.0
morozov 6fa1896
Merge branch '3.5.x' into 4.0.x
morozov e04c9c2
Remove fallback connection to determine platform
morozov d65f50c
Remove SQLite property-based diff workaround
morozov 2cee457
Merge pull request #5710 from morozov/remove-sqlite-property-based-di…
morozov 1a9de6b
Merge pull request #5709 from morozov/remove-platform-detection-fallback
morozov f431acb
Remove default PostgreSQL connection database
morozov 3aa0d3e
Remove default_dbname parameter of wrapper Connection
morozov 51edcd4
Remove exception handling in server version detection
morozov 1544742
Merge pull request #5712 from morozov/remove-try-catch
morozov 34142e5
Merge pull request #5711 from morozov/remove-pdo-pgsql-default-dbname
morozov 4a678e3
Merge branch '3.5.x' into 4.0.x
morozov d2e1619
Merge remote-tracking branch 'origin/3.5.x' into 4.0.x
greg0ire e0ba1bf
Removing deprecated method
nexxai 919d84f
Updated UPGRADE.md
nexxai c9d3753
Merge pull request #5724 from nexxai/4.0.x
derrabus 5015eb7
Remove irrelevant @throws annotation
morozov 286ef0b
Improve ergonomics of invalid colum declaration exceptions
morozov f92d354
Merge pull request #5725 from morozov/issues/5645
morozov 4bd24c8
Convert Doctrine\DBAL\Exception to an interface
morozov 6600b99
Merge pull request #5726 from morozov/exception-interface
morozov c8597bd
Declare NotSupported as LogicException
morozov 7934a63
Declare InvalidColumnType and InvalidColumnDeclaration as LogicException
morozov 5b396d8
Declare exceptions thrown from DriverManager as InvalidArgumentException
morozov 86834ad
Remove redundant @throws annotations
morozov 69d83bb
Merge pull request #5727 from morozov/clarify-exception-semantics
morozov 5e024e7
Merge branch '3.5.x' into 4.0.x
morozov 495dccf
Remove NamedForeignKeyRequired exception
morozov 9a00ace
Remove SchemaException error codes
morozov 2cda730
Merge pull request #5730 from morozov/remove-schema-exception-codes
morozov 3f47978
Merge branch '3.5.x' into 4.0.x
morozov c66a282
Remove obsolete Psalm error suppressions
morozov 25a2ccc
Remove Table methods
morozov 7e284a6
Merge pull request #5733 from morozov/remove-table-methods
morozov 6d2b021
Remove irrelevant @throws annotations
morozov bb16de1
Convert Doctrine\DBAL\Schema\SchemaException to an interface
morozov a8a2650
Merge pull request #5735 from morozov/schema-exception-interface
morozov e7825aa
Merge branch '3.5.x' into 4.0.x
derrabus 5fab12c
Merge branch '3.5.x' into 4.0.x
derrabus c284ea9
Remove deprecated API to register custom SQLite functions
derrabus 22774c0
Merge pull request #5744 from derrabus/remove/sqlite-udf
derrabus f7cb68b
Merge branch '3.5.x' into 4.0.x
morozov 26c481f
Merge branch '3.5.x' into 4.0.x
derrabus 26ece99
Declare internal properties of TableDiff as private
morozov d2c74da
Merge pull request #5753 from morozov/table-diff-internal-properties-…
morozov 0e0818b
Merge branch '3.5.x' into 4.0.x
morozov 0a0cd8a
Remove unit tests that make assertions against complex SQL
morozov d8a5b7c
Merge pull request #5757 from morozov/4.0.x
morozov 7959ea4
Remove user defined SQLite functions
derrabus 7289470
Merge pull request #5759 from derrabus/remove/sqlite-udf
derrabus 73fa2c8
Merge branch '3.5.x' into 4.0.x
morozov 0c08553
Remove handling orphaned foreign keys
morozov 146ae85
Merge pull request #5763 from morozov/remove-orphaned-foreign-keys
morozov bc4a07a
Declare internal properties of SchemaDiff as private
morozov aae1184
Merge pull request #5767 from morozov/schema-diff-internal-properties…
morozov fc39724
Rename parameters of the diff-related methods
morozov 750c448
Merge pull request #5768 from morozov/rename-diff-parameters
morozov 5b40847
Remove obsolete Psalm error suppressions
morozov 763b4ad
Remove array and object column types
morozov 5dfbdee
Remove Table::changeColumn()
morozov a89d540
Merge pull request #5769 from morozov/remove-deprecated
morozov 4a7598d
Merge branch '3.5.x' into 4.0.x
morozov 142e138
Remove SchemaDiff::toSql() and SchemaDiff::toSaveSql()
morozov 26b6351
Merge pull request #5774 from morozov/remove-schema-diff-save-mode
morozov d9825af
Remove Comparator::diffTable()
morozov 88cfa33
Merge pull request #5775 from morozov/remove-comparator-diff-table
morozov deb739f
Remove irrelevant @throws annotations
morozov 639c058
Declare NoColumnsSpecifiedForTable as a LogicException
morozov 2e5aa74
Merge pull request #5777 from morozov/irrelevant-throws-annotations
morozov af7d612
Merge branch '3.5.x' into 4.0.x
morozov a478111
Remove extension via Doctrine Event Manager
morozov 1d70aac
Remove QueryBuilder::getConnection()
morozov 340a882
Merge pull request #5789 from morozov/remove-query-builder-get-connec…
morozov 0c4f7ea
Merge pull request #5788 from morozov/remove-event-manager
morozov bd542a2
Remove trailing whitespace
greg0ire 0f2d257
Merge branch '3.5.x' into 4.0.x
derrabus bf25877
Document breaking changes about serverVersion
greg0ire 59c9495
Merge pull request #5797 from greg0ire/document-bc
derrabus 2e841e9
Merge branch '3.5.x' into 4.0.x
derrabus c66f662
Merge branch '3.5.x' into 4.0.x
derrabus af57bbf
Merge branch '3.5.x' into 4.0.x
derrabus 48be8ba
Merge branch '3.6.x' into 4.0.x
derrabus 06ba8a6
Introduce a ArrayParameterType enum
derrabus 273eff9
Merge pull request #5839 from derrabus/improvement/array-parameter-ty…
derrabus e987d6b
Merge branch '3.6.x' into 4.0.x
derrabus 6073b69
Merge branch '3.6.x' into 4.0.x
derrabus 7986e2e
Remove the "url" connection param
derrabus 851e42d
Merge pull request #5850 from derrabus/remove/url-param
derrabus 5634ab4
Merge branch '3.6.x' into 4.0.x
derrabus 7d1ec27
Explain why the number of affected rows can be a string
GromNaN 1ebb15e
Merge branch '3.6.x' into 4.0.x
derrabus 55645c1
Add missing doc blocks to Index and UniqueConstraint
derrabus 1cf91c1
Merge pull request #5875 from derrabus/bugfix/missing-docblocks
derrabus 4e228a7
Widen the return type of Result::rowCount()
derrabus 6f4b383
Apply suggestions from code review
GromNaN 8c327e2
Merge pull request #5872 from GromNaN/number-string
derrabus 2e5552e
Merge branch '3.6.x' into 4.0.x
derrabus cfc8627
Remove InvalidParameterType exception
derrabus 79d3551
Merge pull request #5879 from derrabus/improvement/row-count-return-type
derrabus cc7ea18
Merge pull request #5896 from derrabus/remove/inv-para-type
derrabus 6b84232
Merge branch '3.6.x' into 4.0.x
derrabus f5bf5ae
Modernize pgsql driver for PHP 8.1
derrabus e543ade
Merge pull request #5904 from derrabus/improvement/modern-pgsql
derrabus c84d330
Merge branch '3.6.x' into 4.0.x
derrabus aec9b17
Fix type assumptions about `Connection::lastInsertId()`
phansys 1295b5f
Merge pull request #5909 from phansys/last_insert_id
derrabus a759917
Merge branch '3.6.x' into 4.0.x
derrabus a7dbdeb
Use "numeric-string" return type for methods that return integers as …
phansys 5921ac0
Merge pull request #5905 from phansys/pr_5879
derrabus ef17dbe
Use closures in portability converter
derrabus 0e8256e
Merge pull request #5936 from derrabus/improvement/typed-portability-…
derrabus c62a3e6
Remove unused private platform methods
derrabus 0f3cce4
Merge pull request #5944 from derrabus/remove/unused-platform-methods
derrabus 6cc39f0
Merge branch '3.6.x' into 4.0.x
derrabus 3b68634
Merge branch '3.7.x' into 4.0.x
derrabus 71168d7
Remove the legacy execution and fetch API
derrabus b4d73f4
Merge pull request #5956 from derrabus/remove/legacy-api
derrabus 5f1ce46
Merge branch '3.7.x' into 4.0.x
derrabus c1125b2
More upgrade documentation for OraclePlatform::getSubstringExpression()
morozov 17f1c0f
Merge pull request #5978 from morozov/issues/5977
morozov d12da23
Merge branch '3.7.x' into 4.0.x
derrabus 95d093a
Merge branch '3.7.x' into 4.0.x
derrabus df2f221
Remove unnecessary type casting of exception codes
morozov 35c548c
Expect row counts to be returned as numeric strings
morozov 26265e9
Use more specific types for schema diffs
morozov d885b87
Use more specific types in query builder
morozov 31bb60f
Rework building parameters in primary-read-replica connection
morozov 3ff4818
Add more assertions against the column counts
morozov f7dd003
Add result set shape assertions to schema managers
morozov 21e931d
Simplify provided test data types
morozov 977b8cc
Remove unused and add missing connection parameters
morozov 6122e2c
Use more specific and correct types in tests
morozov ebdea00
Update Psalm and Jetbrains stubs
morozov 25f8477
Merge pull request #6061 from morozov/psalm-5
derrabus c74c684
SchemaDiff detecting errors in column definition when using custom ty…
janedbal c2ec5e1
Merge branch '3.7.x' into 4.0.x
morozov 02adc27
Mark PHPUnit data providers static
morozov 4ab634b
Remove the test that uses TestCase::getMockForAbstractClass()
morozov bb56a75
Rename abstract test case classes
morozov c23f2ac
Update PHPUnit to 10.2.2
morozov d069d3d
Merge pull request #6065 from morozov/phpunit-10
morozov 3b0813f
Merge branch '3.7.x' into 4.0.x
derrabus 6982657
Psalm 5.13.1 (#6075)
derrabus 54ae67d
Restore reverse lookup determinism (#6097)
greg0ire c97a3e6
Merge branch '3.7.x' into 4.0.x
derrabus 6b76e92
Merge branch '3.7.x' into 4.0.x
derrabus 89dd40d
Drop support for MariaDB 10.2 and 10.3 (#6122)
derrabus f34af0d
Psalm 5.14.1, PHPStorm Stubs 2023.2 (#6124)
derrabus 904ed71
Merge branch '3.7.x' into 4.0.x
derrabus cf8177e
Merge branch '3.7.x' into 4.0.x
derrabus 9128251
Merge branch '3.7.x' into 4.0.x
derrabus c79f853
Merge branch '3.7.x' into 4.0.x
derrabus b8cf896
Remove composer-runtime-api dependency (#6155)
derrabus c41e4db
Merge branch '3.7.x' into 4.0.x
derrabus c031ad0
Stricter `DateTime` types (#6161)
derrabus da025fb
Merge branch '3.7.x' into 4.0.x
derrabus 81c9688
Psalm 5.15.0 (#6167)
derrabus 24af55b
Merge branch '3.7.x' into 4.0.x
morozov 3112306
PHPUnit 10.4.0 (#6123)
derrabus 16c850f
Cast `BIGINT` values to int if possible (#6177)
derrabus a9ae850
Merge branch '3.7.x' into 4.0.x
derrabus 9f24ecb
Merge branch '3.8.x' into 4.0.x
derrabus 792b79d
Merge branch '3.8.x' into 4.0.x
derrabus 9a01fce
Merge branch '3.8.x' into 4.0.x
derrabus aedd3a7
Merge branch '3.8.x' into 4.0.x
derrabus fa47aee
Merge branch '3.8.x' into 4.0.x
derrabus 85e22da
Merge branch '3.8.x' into 4.0.x
derrabus f5be4a2
Merge branch '3.8.x' into 4.0.x
derrabus 6b97ee3
PHPUnit 10.4.2 (#6212)
derrabus 8134e7c
Move `getJsonTypeDeclarationSQL()` to `AbstractMySQLPlatform` (#6216)
derrabus 304e3ec
Merge branch '3.8.x' into 4.0.x
derrabus 44635a2
Remove deprecated lock-related methods (#6219)
derrabus 9adbeca
Remove AbstractMySQLPlatform::getColumnTypeSQLSnippets() (#6214)
ausi 8861620
Relax return types of getExceptionConverter() implementations (#6221)
derrabus 2fdd2f9
Merge branch '3.8.x' into 4.0.x
derrabus aa25d4c
Remove API to disable column comments (#6222)
derrabus 5f544b9
Bump Symfony dependencies (#6224)
derrabus 8006b3e
Merge remote-tracking branch 'origin/3.8.x' into HEAD
greg0ire c3c054f
Merge pull request #6231 from greg0ire/4.0.x
greg0ire 8bc0d9a
Psalm 5.16.0 (#6233)
derrabus 5d88359
Merge branch '3.8.x' into 4.0.x
derrabus 0a3df2e
Merge branch '3.8.x' into 4.0.x
derrabus d98a279
Merge branch '3.8.x' into 4.0.x
derrabus d2aed19
PHPUnit 10.5.9 (#6266)
derrabus 63f294e
Merge branch '3.8.x' into 4.0.x
derrabus 96e6ff1
Use double backticks
greg0ire d0efd5c
Merge pull request #6282 from greg0ire/formatting
SenseException cc65c7b
Merge branch '3.8.x' into 4.0.x
derrabus 755d4cc
Merge branch '3.8.x' into 4.0.x
derrabus 563ea0c
Merge branch '3.9.x' into 4.0.x
derrabus 53df8c4
Merge branch '3.9.x' into 4.0.x
derrabus dc05718
Update branch metadata (#6293)
derrabus ac75c3c
Merge branch '3.8.x' into 4.0.x
derrabus d928827
Psalm 5.21.1 (#6294)
derrabus c6518ac
Update UPGRADE.md
txptr 1a307d9
Merge pull request #6298 from txptr/patch-1
greg0ire 7bbcd10
[Documentation] Adding exact command for Postgres serial migration (#…
ThomasLandauer f41c74a
Merge branch '3.8.x' into 4.0.x
derrabus 1218473
Merge branch '3.8.x' into 4.0.x
derrabus 82fd1b5
Migrate PHPUnit test suite to attributes (#6311)
derrabus f3defbb
Use native intersection types in test suite (#6312)
derrabus c82a62e
Remove Type::canRequireSQLConversion from docs (#6318)
SchmidtClaudia 12bed06
Merge branch '3.8.x' into 4.0.x
derrabus 9e588fe
Merge branch '3.8.x' into 4.0.x
derrabus eef300f
Update UPGRADE.md
kalifg cbc2e57
Merge pull request #6333 from kalifg/patch-1
greg0ire bd7e79f
[Documentation] Adding "versionadded" (#6336)
ThomasLandauer aec34a9
Remove older versions from the docs
SenseException e0219f8
[Documentation] Fixing markup (#6340)
ThomasLandauer d9109cd
Merge pull request #6339 from SenseException/remove-docs
SenseException c70bae9
Merge branch '3.8.x' into 4.0.x
derrabus 03e4554
Add PHP 8.4 to CI
andreybolonin ff2cd96
Update continuous-integration.yml
andreybolonin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,24 +37,19 @@ jobs: | |
os: | ||
- "ubuntu-22.04" | ||
php-version: | ||
- "7.4" | ||
- "8.0" | ||
- "8.1" | ||
- "8.2" | ||
- "8.3" | ||
- "8.4" | ||
dependencies: | ||
- "highest" | ||
extension: | ||
- "pdo_sqlite" | ||
include: | ||
- os: "ubuntu-20.04" | ||
php-version: "7.4" | ||
php-version: "8.1" | ||
dependencies: "lowest" | ||
extension: "pdo_sqlite" | ||
- os: "ubuntu-22.04" | ||
php-version: "7.4" | ||
dependencies: "highest" | ||
extension: "sqlite3" | ||
- os: "ubuntu-22.04" | ||
php-version: "8.1" | ||
dependencies: "highest" | ||
|
@@ -106,15 +101,14 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
- "8.2" | ||
- "8.3" | ||
- "8.4" | ||
oracle-version: | ||
- "18" | ||
- "21" | ||
- "23" | ||
include: | ||
- php-version: "7.4" | ||
oracle-version: "11" | ||
|
||
services: | ||
oracle: | ||
|
@@ -165,15 +159,14 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
- "8.2" | ||
- "8.3" | ||
- "8.4" | ||
oracle-version: | ||
- "18" | ||
- "21" | ||
- "23" | ||
include: | ||
- php-version: "7.4" | ||
oracle-version: "11" | ||
|
||
services: | ||
oracle: | ||
|
@@ -224,9 +217,9 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
postgres-version: | ||
- "9.4" | ||
- "10" | ||
- "15" | ||
- "16" | ||
extension: | ||
|
@@ -236,12 +229,6 @@ jobs: | |
- php-version: "8.2" | ||
postgres-version: "16" | ||
extension: "pgsql" | ||
- php-version: "8.3" | ||
postgres-version: "16" | ||
extension: "pgsql" | ||
- php-version: "8.2" | ||
postgres-version: "16" | ||
extension: "pdo_pgsql" | ||
- php-version: "8.3" | ||
postgres-version: "16" | ||
extension: "pdo_pgsql" | ||
|
@@ -294,11 +281,10 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
mariadb-version: | ||
# keep in sync with https://mariadb.org/about/#maintenance-policy | ||
- "10.0" # Oldest version supported by DBAL | ||
- "10.4" # LTS (Jun 2024) | ||
- "10.4" # Oldest version supported by DBAL, LTS (Jun 2024) | ||
- "10.5" # LTS (Jun 2025) | ||
- "10.6" # LTS (Jul 2026) | ||
- "10.11" # LTS (Feb 2028) | ||
|
@@ -310,22 +296,13 @@ jobs: | |
- "mysqli" | ||
- "pdo_mysql" | ||
include: | ||
- php-version: "8.2" | ||
mariadb-version: "10.6" | ||
extension: "mysqli" | ||
- php-version: "8.2" | ||
mariadb-version: "10.6" | ||
extension: "pdo_mysql" | ||
- php-version: "8.2" | ||
mariadb-version: "11.2" | ||
extension: "mysqli" | ||
- php-version: "8.2" | ||
mariadb-version: "11.2" | ||
extension: "pdo_mysql" | ||
- php-version: "8.3" | ||
mariadb-version: "11.2" | ||
extension: "mysqli" | ||
- php-version: "8.3" | ||
extension: "pdo_mysql" | ||
- php-version: "8.4" | ||
mariadb-version: "11.2" | ||
extension: "pdo_mysql" | ||
|
||
|
@@ -378,7 +355,6 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
mysql-version: | ||
- "5.7" | ||
|
@@ -390,29 +366,17 @@ jobs: | |
config-file-suffix: | ||
- "" | ||
include: | ||
- mysql-version: "5.7" | ||
- mysql-version: "8.0" | ||
# https://stackoverflow.com/questions/60902904/how-to-pass-mysql-native-password-to-mysql-service-in-github-actions | ||
custom-entrypoint: >- | ||
--entrypoint sh mysql:8 -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password" | ||
- config-file-suffix: "-tls" | ||
php-version: "7.4" | ||
php-version: "8.1" | ||
mysql-version: "8.0" | ||
extension: "mysqli" | ||
- php-version: "8.2" | ||
mysql-version: "8.0" | ||
extension: "mysqli" | ||
custom-entrypoint: >- | ||
--entrypoint sh mysql:8 -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password" | ||
- php-version: "8.2" | ||
mysql-version: "8.0" | ||
extension: "pdo_mysql" | ||
custom-entrypoint: >- | ||
--entrypoint sh mysql:8 -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password" | ||
- php-version: "8.3" | ||
mysql-version: "8.0" | ||
extension: "mysqli" | ||
- php-version: "8.3" | ||
extension: "pdo_mysql" | ||
- php-version: "8.4" | ||
mysql-version: "8.0" | ||
extension: "pdo_mysql" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
|
||
|
@@ -469,20 +433,21 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
- "8.2" | ||
- "8.3" | ||
- "8.4" | ||
extension: | ||
- "sqlsrv" | ||
- "pdo_sqlsrv" | ||
collation: | ||
- "Latin1_General_100_CI_AS_SC_UTF8" | ||
include: | ||
- collation: "Latin1_General_100_CS_AS_SC_UTF8" | ||
php-version: "7.4" | ||
php-version: "8.1" | ||
extension: "sqlsrv" | ||
- collation: "Latin1_General_100_CS_AS_SC_UTF8" | ||
php-version: "7.4" | ||
php-version: "8.1" | ||
extension: "pdo_sqlsrv" | ||
|
||
services: | ||
|
@@ -536,10 +501,11 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
- "8.2" | ||
- "8.3" | ||
|
||
- "8.4" | ||
|
||
services: | ||
ibm_db2: | ||
image: "icr.io/db2_community/db2:11.5.8.0" | ||
|
@@ -587,6 +553,8 @@ jobs: | |
|
||
- name: "Install dependencies with Composer" | ||
uses: "ramsey/composer-install@v2" | ||
with: | ||
composer-options: "--ignore-platform-req=php+" | ||
|
||
- name: "Run PHPUnit" | ||
run: "vendor/bin/phpunit -c ci/github/phpunit/ibm_db2.xml --coverage-clover=coverage.xml" | ||
|
@@ -604,7 +572,7 @@ jobs: | |
strategy: | ||
matrix: | ||
php-version: | ||
- "7.4" | ||
- "8.1" | ||
|
||
steps: | ||
- name: "Checkout" | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to test with both extensions!