Fix condition on Ascii String for SQL Server #6389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Please create a test that covers your fix for SQL Server |
SenseException
requested changes
May 16, 2024
SenseException
approved these changes
May 21, 2024
fixed is always set (to either true or false).
greg0ire
force-pushed
the
fix/condition-varchar-sql-server
branch
from
d4651ec
to
04ebb8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR fixes a condition on SQL Server where
fixedis always defined astrueorfalsesoreturn sprintf('VARCHAR(%d)', $length ?? 255);is always ignored.