Make "show databases" sql work correctly. #6397
Conversation
Related issue: doctrine/orm#11411
| @@ -77,7 +77,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $forceFetch = $input->getOption('force-fetch'); | |||
| assert(is_bool($forceFetch)); | |||
|
|
|||
| if (stripos($sql, 'select') === 0 || $forceFetch) { | |||
| $fetchKeywords = ['select', 'show']; | |||
There was a problem hiding this comment.
show is platform specific, right?
There was a problem hiding this comment.
Yes, only mysql work. Should I add some method in Platform class to determine it ?
There was a problem hiding this comment.
We want to avoid platform-specific code in generic classes. Since SHOW is a MySQL extension, sniffing for it here is a no-go.
There was a problem hiding this comment.
Should I add some method in Platform class to determine it ?
I think it feels kinda weird to have a new method in platform classes for the sole purpose of supporting this very specific use case of a feature that is very questionable and secondary (using the DBAL to run arbitrary SQL input by the user), especially since people can use --force-fetch and get the correct result.
There was a problem hiding this comment.
Yeah, I don't think that we should add another layer of guesswork either. I'd rather like to remove the current special handling of SELECT, tbh.
| @@ -77,7 +77,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $forceFetch = $input->getOption('force-fetch'); | |||
| assert(is_bool($forceFetch)); | |||
|
|
|||
| if (stripos($sql, 'select') === 0 || $forceFetch) { | |||
| $fetchKeywords = ['select', 'show']; | |||
There was a problem hiding this comment.
We want to avoid platform-specific code in generic classes. Since SHOW is a MySQL extension, sniffing for it here is a no-go.
|
Close now, I will continue on it when I have more time. |
Related issue: doctrine/orm#11411
Summary