PHPStan 1.11.1 #6399
Merged
PHPStan 1.11.1 #6399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
May 16, 2024
| @@ -184,7 +184,7 @@ public function iterateAssociative(): Traversable | |||
| } | |||
|
|
|||
| /** | |||
| * {@inheritDoc} | |||
| * @return Traversable<int,list<mixed>> | |||
There was a problem hiding this comment.
This was the only error that popped up while removing the checkMissingIterableValueType: false setting, so I decided to fix it instead.
The @inheritDoc statement is nonsense because there's no parent to inherit from.
derrabus
commented
May 16, 2024
| ignoreErrors: | ||
| - identifier: missingType.generics |
There was a problem hiding this comment.
This is the replacement for checkGenericClassInNonGenericObjectType: false. There's too many errors when I just remove the setting, so I decided to keep ignoring this kind of error. We might want to revisit this issue on a higher branch though.
derrabus
commented
May 16, 2024
| @@ -1,14 +1,14 @@ | |||
| parameters: | |||
| level: 8 | |||
| phpVersion: 80200 | |||
| phpVersion: 80300 | |||
There was a problem hiding this comment.
I bumped here to evade phpstan/phpstan#10999
greg0ire
approved these changes
May 16, 2024
derrabus
added a commit
that referenced
this pull request
May 16, 2024
| Q | A |------------- | ----------- | Type | bug | Fixed issues | N/A #### Summary I messed this up in #6399. We cannot make any assumptions regarding key and value here.
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
May 16, 2024
* 3.8.x: Fix return type of iterateKeyValue() (doctrine#6402) PHPStan 1.11.1 (doctrine#6399)
derrabus
added a commit
that referenced
this pull request
May 16, 2024
derrabus
added a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.