Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of supported MariaDB releases #6407

Merged
merged 1 commit into from
May 16, 2024

Conversation

derrabus
Copy link
Member

No description provided.

@@ -6,7 +6,7 @@
use Doctrine\DBAL\Schema\TableDiff;

/**
* Provides the behavior, features and SQL dialect of the MariaDB 10.5 (10.5.2 GA) database platform.
* Provides the behavior, features and SQL dialect of the MariaDB 10.5 (10.5.2 Beta) database platform.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.5.2 is not a GA, but a beta release. Not sure if that suffix provides any value though. Maybe we should drop the suffix (and even the patch level) from this documentation, since nobody can really expect us to support ancient alpha/beta releases of any database.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying the patch level allows us to explicitly say that we don't support 10.5.1, and never will, so there's that. I agree that it's not really our role to remind our users what stability a specific patch version is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the patch level in the docs now, but dropped them from the platform classes. WDYT?

@derrabus
Copy link
Member Author

derrabus commented May 16, 2024

@greg0ire The CodeCov upload failed:

error - 2024-05-16 12:02:16,338 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 254 seconds."}

https://github.com/doctrine/dbal/actions/runs/9111667720/job/25049918068?pr=6407

@derrabus derrabus merged commit 9cf787c into doctrine:3.8.x May 16, 2024
91 of 92 checks passed
@derrabus derrabus deleted the docs/mariadb-platforms branch May 16, 2024 12:37
derrabus added a commit that referenced this pull request May 16, 2024
* 3.8.x:
  Fix documentation of supported MariaDB releases (#6407)
derrabus added a commit that referenced this pull request May 16, 2024
* 3.8.x:
  Fix documentation of supported MariaDB releases (#6407)
derrabus added a commit that referenced this pull request May 16, 2024
* 4.0.x:
  Fix documentation of supported MariaDB releases (#6407)
derrabus added a commit that referenced this pull request May 16, 2024
* 4.1.x:
  Fix documentation of supported MariaDB releases (#6407)
@greg0ire
Copy link
Member

Sadly, I don't think there is anything we can do against that :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants