Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed white gap on right side of page #343

Closed
wants to merge 4 commits into from
Closed

Fixed white gap on right side of page #343

wants to merge 4 commits into from

Conversation

pushpak1300
Copy link

@pushpak1300
Copy link
Author

Can anyone review this pull request?

@SenseException
Copy link
Member

I'll see if I can build the website and test the changes during this week. Please squash your commits in the meantime.

Please use rebase instead of merge when you update your branch with the latest changes of master in the future.

@pushpak1300
Copy link
Author

I am not sure how to squash commit?
can you please provide any resource?

@pushpak1300 pushpak1300 closed this Apr 5, 2020
@pushpak1300 pushpak1300 reopened this Apr 5, 2020
@SenseException
Copy link
Member

Grégoire made in another PR a short howto. Maybe it might help you too: doctrine/orm#8035 (comment)

SenseException
SenseException requested changes Apr 5, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are creating a scroll bar for the document, tested with Desktop Firefox and Chrome. In your issue #341 you mention that this gap is on mobiles but your changes affect all screens and monitor resolutions. Can you adapt your changes für the affected mobile with? How would your expected view look like?

@pushpak1300 pushpak1300 closed this Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pushpak1300 @SenseException